-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: also install the dependencies with pip #1276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximlt
changed the title
CI: try pip again
Also install the dependencies with pip on the CI
Feb 25, 2024
maximlt
changed the title
Also install the dependencies with pip on the CI
CI: also install the dependencies with pip
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings changes to the CI:
pip
. Conda tests are run on a scheduled base, on releases and on part of downstream tests.pip
.Overall, I was impressed by how things improved in the
pip
world, most packages can be installed without any issue on the 3 platforms. Some remaining issues:pygraphviz
has no wheel and requires some special setup to build from the sdist. Since it's just required to build theuser_guide/NetworkX.ipynb
notebook, I've put it in its owngraphviz
extra, that is only pulled when the docs/tests jobs run withconda
.cartopy
cannot be installed on Python 3.8 on Ubuntu and Windows. I've created ageo
extra to deal with that similarly tographviz
. Starting from 3.9 it looks like it will no longer be required!When these dependencies are not installed, the notebooks that need them are skipped.